uutils / uutils/coreutils

CI: fuzz: Run `cargo fmt` and `cargo clippy`

Open
#7,718 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
24.1k
Forks
2k
Avg merge
1d 5h
Merged PRs (30d)
365

Description

Looks like we have no CI test that runs cargo fmt and cargo clippy in fuzz directory.

cd fuzz && cargo fmt does work, so we could add that reasonably easily.

But cd fuzz && cargo clippy doesn't, as it looks like cfg(fuzzing) is not set in that case.

error[E0603]: module `number` is private
  --> fuzz_targets/fuzz_seq_parse_number.rs:9:13
   |
9  | use uu_seq::number::PreciseNumber;
   |             ^^^^^^ private module
   |
note: the module `number` is defined here
  --> /home/drinkcat/dev/coreutils/coreutils/src/uu/seq/src/seq.rs:24:1
   |
24 | mod number;
   | ^^^^^^^^^^

Fixed what was possible to fix in #7717, but we should find a way to automate this.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the fuzz directory by running cargo fmt and cargo clippy, then inspect how cfg(fuzzing) is set and review the changes referenced in #7717. Done means CI automatically runs both checks in fuzz and clippy completes without the reported uu_seq::number visibility error.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
ci-cd, testing-qa
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.