uutils / uutils/coreutils

test_file_column_width_if_filename_contains_unicode_chars started to fail recently

Open
#5,015 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

P - Windows U - df wontfix
Dominant language
Rust
Stars
24.1k
Forks
2k
Avg merge
1d 5h
Merged PRs (30d)
365

Description

Example https://github.com/uutils/coreutils/actions/runs/5390317054/jobs/9785487685?pr=5014


--- TRY 3 STDERR:        coreutils::tests test_df::test_file_column_width_if_filename_contains_unicode_chars ---
thread 'main' panicked at 'assertion failed: `(left == right)`
  left: `"File Mounted on"`,
 right: `"File    Mounted on"`', tests\by-util\test_df.rs:839:5

--- TRY 3 STDERR:        coreutils::tests test_df::test_type_option_with_file ---
thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', tests\by-util\test_df.rs:267:42
stack backtrace:
   0: rust_begin_unwind
             at /rustc/36fb58e433c782e27dd41034284e157cf86d587f/library\std\src/panicking.rs:593:5
   1: core::panicking::panic_fmt
             at /rustc/36fb58e433c782e27dd41034284e157cf86d587f/library\core\src/panicking.rs:67:14
   2: core::panicking::panic
             at /rustc/36fb58e433c782e27dd41034284e157cf86d587f/library\core\src/panicking.rs:117:5
   3: core::option::Option<T>::unwrap
             at /rustc/36fb58e433c782e27dd41034284e157cf86d587f\library\core\src/option.rs:935:21
   4: tests::test_df::test_type_option_with_file
             at .\tests\by-util\test_df.rs:267:19
   5: tests::test_df::test_type_option_with_file::{{closure}}
             at .\tests\by-util\test_df.rs:262:33
   6: core::ops::function::FnOnce::call_once
             at /rustc/36fb58e433c782e27dd41034284e157cf86d587f\library\core\src\ops/function.rs:250:5
   7: core::ops::function::FnOnce::call_once
             at /rustc/36fb58e433c782e27dd41034284e157cf86d587f/library\core\src\ops/function.rs:250:5
   8: core::ops::function::FnOnce::call_once{{vtable.shim}}
             at /rustc/36fb58e433c782e27dd41034284e157cf86d587f/library\core\src\ops/function.rs:250:5
   9: <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once
             at /rustc/36fb58e433c782e27dd41034284e157cf86d587f/library\alloc\src/boxed.rs:1993:9
  10: test::run_test_in_spawned_subprocess
             at /rustc/36fb58e433c782e27dd41034284e157cf86d587f/library\test\src/lib.rs:792:27
  11: test::test_main_static_abort
             at /rustc/36fb58e433c782e27dd41034284e157cf86d587f/library\test\src/lib.rs:185:9
  12: tests::main
             at .\tests\tests.rs:1:1
  13: core::ops::function::FnOnce::call_once
             at /rustc/36fb58e433c782e27dd41034284e157cf86d587f\library\core\src\ops/function.rs:250:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with tests/by-util/test_df.rs at the failing assertions on lines 839 and 267, then reproduce the affected tests using the linked CI run as context. Investigate the recent regression in the Unicode filename column-width and file type-option cases; done means both tests pass with their expected output and without the unwrap panic.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cli, testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
62/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.