`ptx`: Do not use regex when -W options is not provided
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 24.1k
- Forks
- 2k
- Avg merge
- 1d 5h
- Merged PRs (30d)
- 365
Description
ptx rely on regex even when -W option is not provided.
https://github.com/uutils/coreutils/blob/65467ab317d885e14385aa0ff6bb55720160cc88/src/uu/ptx/src/ptx.rs#L118-L141
ptx should break words based on 8-bits charset when gnu extension is enabled or based on [' ', '\t', '\n'] chars when gnu extension is disabled, but don't use regex when -W is not specified.
Ref:
gnu ptx
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/uu/ptx/src/ptx.rs around lines 118-141 and compare the behavior with the GNU ptx reference at src/ptx.c around line 469. Verify how word boundaries should work with and without -W, including the GNU-extension and non-extension cases. Done means ptx avoids regex when -W is absent and uses the specified character sets instead.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100