Missing CI coverage for feat_selinux/feat_smack without an actual SELinux/SMACK kernel
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 24.1k
- Forks
- 2k
- Avg merge
- 1d 5h
- Merged PRs (30d)
- 365
Description
feat_selinux only gets tested in the Build/SELinux job, which boots a Fedora VM with SELinux on purpose. feat_smack isn't built in CI at all. So the 'not enabled' code paths never run anywhere.
Found this in #13311 — a stale Cargo.toml comment claimed both features need an enabled kernel to run, which isn't true, and that wrong assumption hid a real bug where mkdir's SMACK branch silently ignored --context instead of warning. Would be good to have a plain ubuntu-latest job building with both features where neither kernel module is actually on.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the Cargo.toml comment and the existing Build/SELinux CI job to understand how feat_selinux is currently built. Add an ubuntu-latest job that builds with both feat_selinux and feat_smack while neither kernel module is enabled, then verify that the not-enabled paths run and the SMACK mkdir --context behavior is covered.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- ci-cd, testing-qa
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100