cp: --sparse=always hangs if the source is truncated mid-copy
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 24.1k
- Forks
- 2k
- Avg merge
- 1d 5h
- Merged PRs (30d)
- 365
Description
The copy loop in sparse_copy() (src/uu/cp/src/platform/linux.rs) advances only by the bytes read and never handles a zero-byte read:
while current_offset < size {
let this_read = src_file.read(&mut buf)?;
...
current_offset += this_read;
}
size is captured once from the initial metadata(). If the source shrinks afterwards, read() hits EOF and returns 0 before current_offset reaches size, so the loop spins forever at 100% CPU.
Steps to reproduce
$ truncate -s 2G big
$ ( sleep 0.2; truncate -s 0 big ) & # shrink the source mid-copy
$ cp --reflink=never --sparse=always big copy
# never returns; cp pins a core. Interrupt with Ctrl-C.
It's a race window, so adjust the sleep / size if it completes; with a larger source it's easy to hit. GNU cp finishes.
Expected
cp stops at EOF instead of looping forever.
Reported by V12 (finding F-65898).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/uu/cp/src/platform/linux.rs at sparse_copy() and run the provided truncate-based reproducer. Verify that a source truncated during --sparse=always copying reaches EOF and exits instead of spinning, then exercise the relevant copy path with a regression check for this race.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 76/100