fcntl_setpipe_size should handle error cases (EBUSY, EPERM)
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 24.1k
- Forks
- 2k
- Avg merge
- 1d 5h
- Merged PRs (30d)
- 365
Description
fcntl_setpipe_size currently ignores error cases when setting pipe size:
let _ = fcntl_setpipe_size(&mut *dest, MAX_ROOTLESS_PIPE_SIZE);
This can silently drop failures from F_SETPIPE_SZ, which may occur in at least the following cases:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the call to fcntl_setpipe_size and read the F_SETPIPE_SZ error documentation linked in the issue. Determine how EBUSY and EPERM should be surfaced or handled instead of silently ignored, then verify that those error cases are covered by the project's relevant tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- cli, operating-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100