uucore: change sig of detect_system_locale to remove unsafe env::set_var
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 24.1k
- Forks
- 2k
- Avg merge
- 1d 5h
- Merged PRs (30d)
- 365
Description
https://github.com/uutils/coreutils/blob/0b04f5ec69b55c30f6be63a032e7ad51fb37036e/src/uucore/src/lib/mods/locale.rs#L416-L417
This requires many unsafes. Sub issue of https://github.com/uutils/coreutils/issues/12238 .
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read src/uucore/src/lib/mods/locale.rs around lines 416-417 and then review parent issue #12238 for the broader context. Trace detect_system_locale and its callers to determine the signature change needed to remove unsafe env::set_var usage; done means the unsafe requirements are removed without breaking locale detection.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- cli, operating-systems
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100