uutils / uutils/coreutils

How to remove unsafe env::{set_var, remove_var} (at least for 1 thread utility)?

Open
#12,061 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
24.1k
Forks
2k
Avg merge
1d 5h
Merged PRs (30d)
365

Description

There are many unsafe blocks e.g.
https://github.com/search?q=repo%3Auutils%2Fcoreutils+env%3A%3Aset_var&type=code
https://github.com/search?q=repo%3Auutils%2Fcoreutils+env%3A%3Aremove_var&type=code

Can we remove them or use without unsafe{} at least from one-thread utility?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the repository-wide usages of env::set_var and env::remove_var linked in the issue, then identify which usages belong to one-thread utilities. Determine whether those paths can avoid unsafe blocks without changing behavior. Done means the applicable utilities no longer require unsafe environment operations and their existing tests still pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cli
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.