df: Is printing the raw string guarenteed to have the same cell width as using the lossy string?
Open
Beginner friendly
Nobody has claimed this yet.
U - df
- Dominant language
- Rust
- Stars
- 24.1k
- Forks
- 2k
- Avg merge
- 1d 5h
- Merged PRs (30d)
- 365
Description
See this code:
It gets the width of the lossy string but stores the raw bytes. I think this at least deserves a comment explaining this is intentional. Because it's not entirely clear to me if doing a lossy conversion may use more or less cells.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/uu/df/src/table.rs at lines 265-271 and inspect how the lossy string width and raw bytes are used together. Confirm whether the behavior is intentional, then document that relationship with a comment and verify the df-related tests still pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- cli
- Issue type
- Documentation
- Difficulty
- 1/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 72/100