comments in parasplit out of date
Open
Beginner friendly
Nobody has claimed this yet.
U - fmt
- Dominant language
- Rust
- Stars
- 24.1k
- Forks
- 2k
- Avg merge
- 1d 5h
- Merged PRs (30d)
- 365
Description
- "peek ahead" seems pointless
- "need to explicitly force fl out of scope before we can call self.lines.next()" is incorrect because
flis in fact in scope when we callnext(), it seems a refactoring in 01c32a5220ef036bdc1d9bae8928336a815db619 put it in scope.
cc: @tertsdiepraam
Originally posted by @xtqqczze in https://github.com/uutils/coreutils/pull/10754#discussion_r2771509208
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Find the Rust implementation of parasplit and inspect the comments containing "peek ahead" and the note about forcing fl out of scope. Update those comments so they match the current scope and refactored behavior; done means neither comment describes behavior that the code does not use.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- cli
- Issue type
- Documentation
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 65/100