uselagoon / uselagoon/lagoon-cli

[deploy branch command] Exit code returns 0, should return > 0 for errors

Open
#189 5 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug easy lagoon-upstream
Dominant language
Go
Stars
28
Forks
14
Avg merge
1d 2h
Merged PRs (30d)
1

Description

Describe the bug
Exit code returns 0, should return > 0 for errors

To Reproduce
cool-project is a dummy project name

$ lagoon deploy branch -p cool-project -b master
Error: UnknownActiveSystem: Unknown active system 'lagoon_kubernetesBuildDeploy' for task 'deploy' in for project cool-project
$ echo $?
0

Expected behavior

$ lagoon --force deploy branch -p cool-project -b master
Error: UnknownActiveSystem: Unknown active system 'lagoon_kubernetesBuildDeploy' for task 'deploy' in for project cool-project
$ echo $?
255

Exit codes are a number between 0 and 255

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the lagoon deploy branch -p cool-project -b master command and inspect how its reported error is converted into a process exit status. Done means the shown deployment error returns a nonzero exit code, such as 255, while successful commands retain exit code 0.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.