[BUG] 3.0.4 breaks compatibility by changing signal arguments
@penguinolog is already working on this.
Since Dec 10, 2025.
Assessment
This issue has not been assessed yet.
Description
urwid 3.0.4 broke pudb, see https://github.com/inducer/pudb/issues/715. This seems to have been the result of #1079, where it is not clear to me whether the compatibility implications of this change were adequately considered. The arguments received by the signal are now wrapped in a singleton tuple, when previously, the were not. I don't think I saw deprecation warnings that would have allowed pudb to adapt.
In adapting to this unwelcome compatibility break, I've switched to using functools.partial to supply the argument, forgoing user_data entirely. Since it seems unnecessary, maybe the right approach would be to restore compatibility and to deprecate the mechanism outright, since it doesn't really seem necessary?
- Dominant language
- Python
- Stars
- 3k
- Forks
- 344
- Avg merge
- 2h 5m
- Merged PRs (30d)
- 79
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from urwid/urwid
-
set_alarm_in callbacks: a wrong signature kills the entire MainLoop with a misleading traceback OpenEvent loop Feature
Difficulty 4/5 3-5 days Newbie friendliness 48/100
-
Feature proposal Waiting for response Widget
Difficulty 4/5 3-5 days Newbie friendliness 55/100
-
docs
Difficulty 3/5 1-2 days Newbie friendliness 50/100
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 45/100
-
[Question] Openquestion
Difficulty 3/5 1-2 days Newbie friendliness 20/100
Similar issues
-
area/auth bug comp/agent P3 platform/discord type/security
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
NousResearch/hermes-agent#117848 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
bancolombia/sentinel#23 ·
-
test md OpenCI
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
integration:quickjs org:external priority:backlog topic:code-interpreter topic:middleware type:feature
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
langchain-ai/deepagents#6450 ·
-
bug client
Difficulty 2/5 1-3 hours Newbie friendliness 88/100