unjs / unjs/hookable

Debugger handling parallel hook calls with same name

Open
#57 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
960
Forks
43
Avg merge
19m
Merged PRs (30d)
1

Description

Context: https://github.com/unjs/hookable/pull/55

Implementation with has some issues still for tracking parallel hook calls with certain timing cases:

(#id indicates assigned event._id we use to pad and add hidden diff and (!) issue)

#0: |----------------| (logEnd #0)
    ctr=1           ctr=1
#1:     |------------------------| (logEnd #1) (!)
        ctr=2                    ctr=1
#1:                        |----------------------| logEnd(#1) (!)
                           ctr=2                  ctr1=

We also need to add tests for better coverage

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing pull request #55 and the timing diagram in this issue to understand the current parallel hook-call tracking. Locate the existing hook tests, reproduce the shown same-name timing cases, and consider the work complete when those cases are handled and regression coverage has been added.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.