unitycatalog / unitycatalog/unitycatalog

[hadoop] set renewable credential to true permanently

Open
#1,762 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
3.5k
Forks
672
Avg merge
6d 16h
Merged PRs (30d)
30

Description

Currently, the credential properties for Hadoop are produced via the buildForTable family of public APIs. It takes in a boolean credentialRenewalEnabled which determines the following:

If renewal is enabled, then the custom token provider is injected into the Hadoop conf. Then a set of credentials are written to custom keys for the custom token provider to pick up.

If renewal is not enabled, then no custom token provider is injected. Instead, the credentials are written to keys that the underlying cloud file system will pick up ie S3A file system.

However, in either case, the credentials are still vended from UC. In other words, both paths ask UC for credentials. Then there is no point in turning off renewal as regardless of if credentialRenewalEnabled is true or false, either path will have the necessary information to encode the credential renewal details into the Hadoop conf.

Investigate whether or not it is safe to remove this parameter and always enable renewal credentials. This will greatly simplify the code design for maintainability.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the buildForTable family of public APIs and trace how credentialRenewalEnabled selects the Hadoop credential paths. Compare both branches to verify whether renewal details are available in each case; done means confirming it is safe to remove the parameter and always enable renewal without losing required credential behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend, data-engineering
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.