unisonweb / unisonweb/share-api

Changes across branches fail to render data constructors

Open
#25 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Haskell
Stars
31
Forks
3
PR merge metrics
No merged PRs in 30d

Description

There are a few cases where clicking "expand" on the Changes view of a term on Share directs the user to a "Page not found" separate page or produces an error instead of displaying the changes. Changing the data constructors of a type and filing a PR is one such case!

In an effort to help minimize the surface area of things, here's a project with a simple PR demonstrating the issue.

Notes:

  • transitive changes appear to render as expected
  • in this PR, it's just the data constructors that create the error, not other actual code changes.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked Share project and simple PR, then reproduce the Changes view by expanding the term change. Compare the constructor-only change with the transitive changes that already render correctly. Done means data-constructor changes display their changes instead of producing an error or a Page not found page.

Written by the indexing model from the issue text.

Assessment

Tech stack
haskell
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.