Refactor convert_wildcard_to_*
Open
Nobody has claimed this yet.
enhancement
good first issue
- Dominant language
- Python
- Stars
- 2
- Forks
- 7
- Avg merge
- 6d 11h
- Merged PRs (30d)
- 2
Description
It probably makes sense to refactor convert_wildcard_to_filter and convert_wildcard_to_regex after #134 gets resolved.
convert_wildcard_to_filter isn't in use. Maybe just remove it?
convert_wildcard_to_regex might lead to this pattern:
params = {}
param, value = convert_wildcard_to_regex('name', args.name)
params[param] = value
Make input and output a dict probably makes more sense:
params = convert_wildcard_to_regex({'name': args.name})
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
First review issue #134, then locate convert_wildcard_to_filter and convert_wildcard_to_regex and inspect their callers. Confirm whether the filter helper is unused and determine the intended dictionary input/output for the regex helper. Done means the refactor is consistent with the CLI’s existing wildcard behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cli
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100