unic / unic/unic-agents-plugins

Demo the run's output to Jessi and decide whether integration/dlc reaches develop

Open
#503 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

app:unic-archon-dlc needs-specs p1 wayfinder:task
Dominant language
JavaScript
Stars
1
Forks
0
Avg merge
16h 43m
Merged PRs (30d)
19

Description

Question

Does the run's output reach develop?

This is act 2 of the delivery split decided while charting. Act 1 is inside run 4: /qa merges to
integration/dlc. Act 2 is this ticket, and it is deliberately outside the run, so develop receives a
component by a human decision rather than as a side effect of a measurement.

How the decision is taken

The maintainer and Jessi, together, on a shared screen, from a locally-run Storybook. Jessi does not
review code she does not understand, and the Consumer has no CI to publish Storybook — giving it one is
out of scope, on #373. So what is judged is
what renders.

"Storybook runs locally and shows the component" is therefore a precondition of this ticket, not a
detail. Confirm it before the call is booked, not during it.

What resolving this produces

  • The decision, recorded: merged or not, and what was seen.
  • If merged: integration/dlcdevelop as an ordinary pull request, and
    #379's remaining criteria verified against
    origin/develop.
  • If not merged: what was wrong, and whether it is a plugin defect, a design mismatch or a slice that was
    never going to render. The answer decides whether run 5 exists at all.

Two costs already recorded

  • A push --force with a reset on integration/dlc destroys the baseline run 5 would use. If it is
    reset, that is a decision, not a tidy-up.
  • integration/dlc diverges from develop while this ticket waits. A slow act 2 leaves any later run
    building on a stale base.

Not decided

  • How long act 2 may wait before the divergence is the bigger problem.
  • Whether Jessi sees the pull request at all, or only the rendered component.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

First confirm that Storybook runs locally and shows the component before arranging the shared-screen review with Jessi and the maintainer. Record what was seen and whether integration/dlc is merged into develop; if merged, verify #379's remaining criteria against origin/develop, otherwise document the defect, design mismatch, or non-rendering slice.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, storybook
Domain
frontend, release
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.