Return a wrong type getEventDataEvents: object instead of object[]
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 68/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- typescript
- Domain
- api
Research direction
Start at the TypeScript declaration for getEventDataEvents(websiteId, params) and inspect its current ApiResponse type. Confirm that the event result is an array, then update the return type to ApiResponse<Umami.WebsiteEventData[]> and verify the declaration compiles.
Written by the indexing model from the issue text.
Description
Hi,
thank you for your work.
I think the types on getEventDataEvents should get Umami.WebsiteEventData[]
instead of Umami.WebsiteEventData to return a right type?
getEventDataEvents(websiteId: string, params: {
startAt: number;
endAt: number;
event?: string;
}): Promise<ApiResponse<Umami.WebsiteEventData[]>>;
- Dominant language
- TypeScript
- Stars
- 47
- Forks
- 18
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from umami-software/api-client
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
umami-software/api-client#26 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 32/100
umami-software/api-client#25 ·
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 48/100
umami-software/api-client#24 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 32/100
umami-software/api-client#20 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 28/100
umami-software/api-client#17 · 2 comments ·
All issues in umami-software/api-client
Similar issues
-
clawsweeper:fix-shape-clear clawsweeper:queueable-fix clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster no-stale P3
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 76/100
-
code-quality refactoring
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
github/gh-aw-firewall#8816 ·
-
integration:quickjs org:external priority:backlog topic:code-interpreter topic:middleware type:feature
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
langchain-ai/deepagents#6450 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
vercel/react-tweet#225 ·