ukaea / ukaea/PROCESS

TF coil geometry not well documented and not very precise

Open
#603 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Documentation TF Coil Triaged
Dominant language
Python
Stars
71
Forks
27
Avg merge
2d 18h
Merged PRs (30d)
33

Description

In GitLab by @mkovari on Jan 24, 2018, 09:08

The html output contains some very useful images.

  • 1. The image TFWindingPack.png has some discrepancies, which make it impossible to understand the TF coil geometry precisely:

Variables radwp, bcylth, tcan1, tcan2 and tcan3 are shown but do not exist.
Features and variables not shown:

thkcas: (inboard TF coil case outer (non-plasma side) thickness) 
casthi: inboard TF coil case plasma side thickness
casths: inboard TF coil sidewall case thickness 
thicndut: conduit insulation thickness (m) 
tfinsgap: TF coil WP insertion gap
thwcndut: TF coil conduit case thickness (m) (iteration variable 58)
tinstf: ground insulation thickness surrounding winding pack (m) 
rbmax : radius of maximum TF B-field (m) 
  • 2. The radial build for the centre-line of the TF coil should be included.
  • 3. It would be very nice to plot the TF winding pack diagram to scale. This would certainly help to identify errors and apparent discrepancies with results from other codes, and to liaise with the CAD designers.
  • 4. This description is confusing:
bmaxtfrp : peak field at conductor with ripple (T)

as most people use the term ripple only for the outboard side. Perhaps we should write

bmaxtfrp : peak field at discrete cable (radius rbmax) (T)
  • 5. The peak field is calculated at radius rbmax, given by
rbmax = rcoil - casthi

This is not very accurate. The actual winding array doesn't include the insertion gap tfinsgap and the ground insulation thickness surrounding winding pack tinstf.

  • There is a discrepancy in the radial build of the TF coil, equal to twice the ground insulation thickness.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the HTML output and the TFWindingPack.png diagram, then trace the listed TF-coil geometry variables and the radial-build calculation. Done means the documented variables and radial build agree with the geometry, the peak-field radius accounts for the stated gaps and insulation, and the winding-pack diagram is accurate and to scale.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
documentation
Issue type
Documentation
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.