Reduce duplication of geometry dataclasses in `tfcoil/superconducting.py`
Open
Nobody has claimed this yet.
papercut
- Dominant language
- Python
- Stars
- 71
- Forks
- 27
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 33
Description
Not a comment for you Jack, I think this class can inherit from CICCAveragedTurnGeometry which will reduce duplication. Will make an issue.
Originally posted by @timothy-nunn in https://github.com/ukaea/PROCESS/pull/4591#discussion_r3978246397
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in tfcoil/superconducting.py by comparing the geometry dataclasses with CICCAveragedTurnGeometry and tracing their uses. Refactor the relevant class to inherit from CICCAveragedTurnGeometry, then run the applicable PROCESS tests and confirm the geometry behavior remains unchanged without duplicated definitions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100