Possible duplicate variable
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 71
- Forks
- 27
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 33
Description
f_nd_impurity_electrons and f_nd_impurity_electron_array are in impurity_radiation_variables.py and seem to be equal to each other.
In check_process(), f_nd_impurity_electron_array is set to equal f_nd_impurity_electrons:
And at the end of a process run the two arrays remain equal:
Do we need both these variables?
(Not sure if this may be related to #463 ?)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in impurity_radiation_variables.py and inspect check_process(), then search the repository for both variable names to compare their uses. Trace how each array is assigned and read during a process run. Done means establishing whether they are redundant and, if so, consolidating them without changing the observed process behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100