ukaea / ukaea/PROCESS

hfact uses wrong loss power index

Open
#4,443 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
71
Forks
27
Avg merge
2d 18h
Merged PRs (30d)
33

Description

This will only work for the selected scaling if the loss power index is (1-0.31), so really just the IPB98 scalings in this case

https://github.com/ukaea/PROCESS/blob/c4a5893f228c00529e931f1b79cae4bb02f569fa/process/models/physics/confinement_time.py#L953-L966

Originally posted by @chris-ashe in #4396

@chris-ashe please feel free to update the title and issue body since you know what the actual issue is

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in process/models/physics/confinement_time.py around lines 953-966 and trace how hfact selects the loss power index for each scaling. Compare the selected-scaling logic with the IPB98 case described in the issue. Done means hfact uses the appropriate loss power index rather than assuming 1-0.31.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.