ukaea / ukaea/PROCESS

"ITV" label

Open
#4,313 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Blocked Data structure Input/Output Files
Dominant language
Python
Stars
71
Forks
27
Avg merge
2d 18h
Merged PRs (30d)
33

Description

To enable the dataclass conversion of numerics.py, these lines have been commented out:

Image

as there was no way to access the name_xc variable without passing it into every instance of ovarre.

This functionality should be added back in

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in numerics.py by locating the commented-out lines and the ovare dataclass conversion. Trace how name_xc is currently accessed and review nearby tests or call sites before deciding how the functionality should return without passing it into every ovare instance. Done means dataclass conversion remains enabled and the ITV-related name_xc behavior is restored.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.