Negative radii bug in sctfcoil module
Open
@chris-ashe is already working on this.
Since Oct 31, 2024.
- Dominant language
- Python
- Stars
- 71
- Forks
- 27
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 33
Description
When attempting to optimise a spherical tokamak problem, I encountered a convergence error from optimize.newton() in Sctfcoil.supercon(). This turned out ultimately to be due to negative radii causing maths errors (-ve square roots, logs), which when kludged (https://github.com/jonmaddock/process-fork/tree/st-sctfcoil-kludges), causes the Newton solver to converge again.
It would obviously be preferable to fix the model to avoid these unphysical negative radii, which appear to be more prevalent in ST designs.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.