There are several checks in constraint_equations that should go into init
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 71
- Forks
- 27
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 33
Description
In GitLab by @pc6783 on Mar 17, 2022, 16:07
There are currently at least 8 checks that occur in the various subroutines of constraint_equations.f90 that should instead go in the subroutine check in initial.f90. These are things like checking whether the machine is an ST or not and throwing an error.
These should instead go into check
Thanks @skahn for pointing this out
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the checks in constraint_equations.f90 and the check subroutine in initial.f90. Identify the checks that validate conditions such as whether the machine is an ST, then centralize them in initial.f90's check subroutine. Done means the relevant checks no longer occur in the constraint_equations subroutines and are handled by check.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- fortran
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100