ukaea / ukaea/PROCESS

Errors in regression tests when infinity values are involved

Open
#1,565 0 comments 0 reactions 1 assignee View on GitHub

@jonmaddock is already working on this.

Since Jul 7, 2023.

Testing
Dominant language
Python
Stars
71
Forks
27
Avg merge
2d 18h
Merged PRs (30d)
33

Description

In GitLab by @mn3981 on Feb 11, 2022, 09:06

Summary

Regression tests will fail in pytest if one of the compared values is infinity. This is known to be a problem in the hts_REBCO and FNSF tests, though these may not be the only ones. The error cannot be fixed by overwriting pytest and requires a manual re-writing of the MFILE. No indication is given that these tests are failing when locally running pytest but will show a failure on GitLab CI. The variable "drsep" is known to be affected by this error though it may apply to all.
Examples of such errors can be seen in issue #1559

Checklist

After fixing bug do the following

  • Run test suite
  • Does it change the output? If so, give justifications.
  • Does it change the baseline 2019 run? (you may need to run on Freia)
  • Merge request created

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.