ukaea / ukaea/PROCESS

eff_tf_cryo needs to be an input but keeping the existing default values

Open
#1,431 2 comments 0 reactions 1 assignee View on GitHub

@jmorris-uk is already working on this.

Since Oct 22, 2024.

  • #3492 by @jmorris-uk — open
Dominant language
Python
Stars
71
Forks
27
Avg merge
2d 18h
Merged PRs (30d)
33

Description

In GitLab by @cjwgriesel on Oct 20, 2021, 14:40

in plant_power.f90
real(8) :: eff_tf_cryo
!! TF cryoplant efficiency (compared to pefect Carnot cycle).
!! Using -1 set the default value depending on magnet technology:
!!
!! - i_tf_sup = 1 : SC magnet, eff_tf_cryo = 0.13 (ITER design)
!! - i_tf_sup = 2 : Cryo-aluminium, eff_tf_cryo = 0.4

eff_tf_cryo needs to have the option of being an input as there is a wide range of cryogenic efficiencies. From 13% to 40% according to the strobridge curve and manufacturers literature.

Change this line in plant_power.f90 so it gives the input efficiency regardless of the type of magnet HTS or CRYO AL. This is misleading as it is always displayed regardless of the choice of magnet material/type.
call ovarre(outfile,'Efficiency (figure of merit) of cryogenic plant is 13% of ideal Carnot value:', &
'', (0.13D0*tmpcry)/(293.0D0 - tmpcry), 'OP ') with 0.13 replaced by eff_tf_cryo etc

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.