ukaea / ukaea/PROCESS

Impurity Radiation Models

Open
#1,012 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Impurities
Dominant language
Python
Stars
71
Forks
27
Avg merge
2d 18h
Merged PRs (30d)
33

Description

In GitLab by @asbrown on Feb 14, 2020, 17:13

Summary

There are currently two impurity radiation models in PROCESS: the first calculates the impurity radiation in the core of the plasma; while the second calculates the impurity radiation for the divertor region. Each model calculates the same impurity radiation and draws from separate impurity radiation tables, each from Martin O'Mullane, which are effectively the same.

This is a duplication models and data which when resolved will simplify PROCESS by reducing unnecessary code and removing redundant files/folder.

Checklist

After implementing issue do the following

  • Run test suite
  • Does it change the output? If so, give justifications.
  • Does it change the baseline 2019 run? (you may need to run on Freia)
  • Merge request created

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue concerns duplicate core and divertor impurity-radiation models and their separate tables, but it names no files or tests. Locate both model implementations and data directories first, then run the test suite and compare the 2019 baseline to confirm whether consolidation changes output.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.