Embedded base64 images are not working after update from 3.26.5 to 4.0.1
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 2.9k
- Forks
- 201
- Avg merge
- 12m
- Merged PRs (30d)
- 1
Description
I'm facing an issue where images are no longer displayed after updating from react-md-editor v. 3.26.5 to v 4.0.1. We're embedding the images in the markdown string and displaying them using references. This used to work, but now renders an img tag with an empty source string.
Repro:
<MDEditor.Markdown source="This is my example:\n\n![][example.png]\n\n[example.png]: data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAgAAAAIAQMAAAD+wSzIAAAABlBMVEX///+/v7+jQ3Y5AAAADklEQVQI12P4AIX8EAgALgAD/aNpbtEAAAAASUVORK5CYII" />
Edit: I have found a link to a Markdown Syntax Guide that describes this implementation. They call it "Reference Links": Link to article.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the MDEditor.Markdown entry point and reproduce the provided reference-link example using the embedded base64 image. Trace how the markdown reference is converted into the rendered img tag. Done means the image renders after the update and its source is no longer empty.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100