uiwjs / uiwjs/react-md-editor

Remove browserslist "not dead" from package.json in v3.3.3

Open
#449 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
2.9k
Forks
201
Avg merge
12m
Merged PRs (30d)
1

Description

Hi @jaywcjlove, we are restricted to use v3.3.3 because of react version and loader issues.
But when we make a build of our CRA app we get into a build error caused by borwserslist

ERROR in ./node_modules/@uiw/react-md-editor/lib/esm/components/Toolbar/index.css (./node_modules/css-loader/dist/cjs.js??ref--5-2!./node_modules/postcss-loader/src??ref--5-3!./node_modules/@uiw/react-md-editor/lib/esm/components/Toolbar/index.css)
    Module build failed (from ./node_modules/postcss-loader/src/index.js):
    BrowserslistError: Unknown browser query `dead`

We found that removing "not dead" from browsers list fixed the issue.
Can we remove "browserslist": {} from package.json for this specific version or you could create a patch version fix for this?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with package.json for the v3.3.3 release and inspect the Browserslist configuration containing "not dead". Reproduce the CRA build error if possible, then verify that the configuration no longer causes the BrowserslistError for the editor CSS build.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.