uiwjs / uiwjs/react-md-editor

Dark mode support opt-out

Open
#448 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
2.9k
Forks
201
Avg merge
12m
Merged PRs (30d)
1

Description

Hi, thanks for this great package.
We use the Markdown components for our UI kit in our organization which is shared between projects.

We recently bumped up this package from v3.4.0 to v3.14.4. in our UI kit and the dark mode support breaks(dark bgs for some users) our components which use the Markdown component.

Is there a way to opt out of this dark mode support? Perhaps with a config?

I'm aware of the ways of forcing either light or dark mode (by setting the data-color-mode attribute) but they aren't practical for our use case because our components all encapsulate their styles and setting the attribute for all our apps may break future dark mode support and require code changes across a lot of files.

Thank you.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the package's dark-mode support and its existing data-color-mode behavior. Define how consumers can opt out without changing attributes across their applications; done means the Markdown component can avoid dark-mode styling through a documented configuration or equivalent option.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.