uiwjs / uiwjs/react-md-editor

Support custom components for toolbar options

Open
#419 13 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
2.9k
Forks
201
Avg merge
12m
Merged PRs (30d)
1

Description

Hi @jaywcjlove,

Can we please add support for using a custom component for the toolbar buttons?

I'm trying to add Material UI styling. With MUI 5, you cannot generate a class name for a button?! If we can provide a styled component to override the button element, that would be awesome :)

We'll need to update this section:

https://github.com/uiwjs/react-md-editor/blob/master/core/src/components/Toolbar/index.tsx#L90

to allow custom components to be provided.

Thoughts?

Cheers,

Kyle

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in core/src/components/Toolbar/index.tsx around line 90, where toolbar buttons are defined. Trace how toolbar options are rendered and determine how a caller could provide custom components for those buttons. Done means custom components can be supplied for toolbar options and support the requested Material UI styling use case.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.