uiwjs / uiwjs/react-md-editor

Render crashing syntax bug

Open
#262 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
2.9k
Forks
201
Avg merge
12m
Merged PRs (30d)
1

Description

I've noticed that when you try for example add code like this:

<p align="center">
    <img src="https://i.pinimg.com/originals/ec/b3/45/ecb3455c4ab0058ec05769a7e9f93e49.gif" />
</p>

and then by mistake if you remove the space between img and src

<p align="center">
    <imgsrc="https://i.pinimg.com/originals/ec/b3/45/ecb3455c4ab0058ec05769a7e9f93e49.gif" />
</p>

this results in this error and failing to render anything.

Uncaught DOMException: Failed to execute 'createElement' on 'Document': 
The tag name provided ('imgsrc="https:') is not a valid name.

This is UX breaking problem, which I think should be fixed quickly.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the malformed HTML example in the editor preview and trace the rendering path that handles the invalid imgsrc tag. Confirm the current DOMException, then verify that the preview no longer crashes and that valid HTML still renders.

Written by the indexing model from the issue text.

Assessment

Tech stack
markdown, react, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.