uiwjs / uiwjs/react-codemirror
Event missing using keymap
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 2.3k
- Forks
- 161
- PR merge metrics
- No merged PRs in 30d
Description
Hello sr!
For some reason that I ignore, after upgrading version (I guess that was what happen), I stop getting the event in the handler of an extra key specified in keymap (and I do need to stop event propagation):
<CodeMirror
extensions={[Prec.highest(keymap.of(this.extraKeys()))]}
theme={this.theme()}
value={value}
onChange={this.valueChanged}
/>
extraKeys() {
return [
{
key: "Enter",
run: this.enterPressed,
},
{
key: "Shift-Enter",
run: this.enterPressed,
},
];
}
enterPressed = (editor, event) => {
if (event.shiftKey || event.altKey) {
event.stopPropagation();
return;
}
event.preventDefault();
if (this.props.onAccept) this.props.onAccept();
this.clear();
return true;
};
Any help is wellcome. Thanks!
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the reported Enter and Shift-Enter behavior from the keymap.of and extraKeys handler shown in the issue. Trace the event handling entry point and verify that the handler receives the expected event and stops or prevents propagation as described when the issue is resolved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100