uiwjs / uiwjs/react-codemirror

change tsconfig 'react-jsx' to 'react'

Open
#561 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
2.3k
Forks
161
PR merge metrics
No merged PRs in 30d

Description

Now in tsconfig.json, it sets jsx 'react-jsx',this make JSX Syntax will be transformed to jsx,and jsx is referenced from 'runtime/react-jsx',but 'runtime/react-jsx' is not allowed in all React versions。When use react@16.13.0,it has error " Can't resolve 'react/jsx-runtime'".Should it be changed from 'react-jsx' to 'react',so it can transformed to React.createElement?
image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting tsconfig.json and the current jsx setting. Reproduce the reported resolution error with react@16.13.0, then verify whether using the classic React JSX transform resolves it without breaking the project’s supported React versions. The issue is done when the configuration works with that React version and the relevant checks pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.