ucdavis / ucdavis/Purchasing

Approval Notifications

Open
#443 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feedback
Dominant language
C#
Stars
7
Forks
5
PR merge metrics
No merged PRs in 30d

Description

I just had a scenario where the Conditional Approver denied an order because they thought the Initial Approver had already approved the first Approval stage, and there were requirements missing from that first stage since it hadn't yet been completed. The Conditional Approver thought (as did I) that they would only be notified of an order once the initial Approver stage was complete, and they didn't check whether the Approval Status for the first Approver was complete (it was still "Pending").

This could just be user oversight, and I don't know the exact behavior or email content since I'm not an approver, but my thinking is it would make sense to notify all approvers when an order is created, and show clearly that the notification is for an "Order Created" event, and then maybe notify each Approver when the previous approval stage is complete with an "Approval Required" notification (could also notify on other important events?). Maybe this is already the case, I don't know since I can't test it as an approver, but if not, I think it would be a useful feature to add.

Votes: 1
Author: rsynnest
Voters: rsynnest

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by reviewing the existing approval-stage workflow and notification or email behavior, then clarify the distinction between “Order Created” and “Approval Required” events with maintainers. Done should be defined by agreed notification timing and clearly labeled messages for approvers.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.