ucdavis / ucdavis/Purchasing

Don't strip line breaks out of notes

Open
#350 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feedback
Dominant language
C#
Stars
7
Forks
5
PR merge metrics
No merged PRs in 30d

Description

Line breaks/carriage returns in notes (whether in purchase line items or Order Notes) are stripped out when requests are submitted. They should be left intact.

Line breaks are often extremely useful to increase readability of notes. Currently all notes are a munged text block, which can be difficult to parse unless they're very small.

Line breaks should not be stripped out of request notes. If there is a concern about the possibility of too many line breaks being put into notes, perhaps a compromise could be reached, like stripping them out after three consecutive ones.

Charles F Sievers III on August 28, 2013 09:13 (2 comments) Public permalink

Votes: 1
Author: jsylvest
Voters: jsylvest

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing request submission for notes in purchase line items and Order Notes, then identify where line breaks and carriage returns are removed. Done means submitted notes preserve their existing line breaks in both locations, with the behavior verified for ordinary and multiline notes.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.