uber / uber/rides-android-sdk

Unable to customize RideRequestButton text size

Open
#34 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Java
Stars
293
Forks
132
PR merge metrics
No merged PRs in 30d

Description

In small screens, the given RideRequestButton has UI glitches: Text is so big, button is huge...
I really recommend letting developers customize the button label, estimate and price text size.

Here is a proposal to fix this:
https://github.com/uber/rides-android-sdk/pull/35

screenshot_2016-07-09-22-46-58

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the linked pull request #35 and the RideRequestButton implementation to understand the proposed customization points. Verify the behavior on small screens shown in the screenshot, then confirm that developers can control the label, estimate, and price text sizes without the button becoming oversized.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
mobile
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.