uber / uber/h3

Expose error codes for normalizeMultiPolygon

Open
#628 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
6.5k
Forks
627
Avg merge
3d 21h
Merged PRs (30d)
6

Description

Motivated by a few comments in #619 (1, 2).

normalizeMultiPolygon has its own set of error codes. Instead of a separate error system, we should combine it with the current error system that we expose in the API.

Upside: Single, unified error system.
Downside: These errors may not ever actually get exposed to the user.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/h3lib/include/linkedGeo.h, where normalizeMultiPolygon's separate error codes are defined, and compare them with the error system exposed by the API. Trace how both systems are used and determine the unified error mapping; done means normalizeMultiPolygon no longer maintains a separate error system.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
api
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.