Add tests for hexRange/gridDiskUnsafe
Open
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 6.5k
- Forks
- 627
- Avg merge
- 3d 21h
- Merged PRs (30d)
- 6
Description
Per https://github.com/uber/h3/pull/403#discussion_r517018785
We don't have any direct tests for hexRange, and while they're covered in the current kRing tests this is an implementation detail that shouldn't be reflected in tests.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the existing kRing tests and locating the hexRange and gridDiskUnsafe entry points. Review the linked pull-request discussion for the intended test boundary, then add direct tests for hexRange without making kRing tests depend on that implementation detail. Done means the direct coverage is present and the existing tests still pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100