Refactor `bbox.c` code to use radians instead of kilometers
Open
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 6.5k
- Forks
- 627
- Avg merge
- 3d 21h
- Merged PRs (30d)
- 6
Description
For example:
Radians would be more natural, especially when considering spheres that aren't the Earth.
Also, we might want to use the new area/length functions for things like pentagonAreaKm2 and pentagonRadiusKm in the code?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the referenced section of src/h3lib/lib/bbox.c around lines 100-111 and trace how distances and areas are represented. Review the existing area/length functions and the uses of pentagonAreaKm2 and pentagonRadiusKm. Done means the related calculations consistently use radians where appropriate, including the pentagon values.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100