Fix testing Windows shared object build
@isaacbrodsky is already working on this.
Since Jul 7, 2020.
- Dominant language
- C
- Stars
- 6.5k
- Forks
- 627
- Avg merge
- 3d 21h
- Merged PRs (30d)
- 6
Description
As noted in #365 it looks like build is broken without using -DBUILD_TESTING=OFF and -DBUILD_GENERATORS=OFF. This means we can't run the tests on shared object builds.
The issue with h3WithTestAllocators is probably the same as was seen on Mac OSX where a special build option is needed to have unknown symbols be looked up dynamically. Edit: Perhaps this can be done with https://docs.microsoft.com/en-us/cpp/build/reference/force-force-file-output?view=vs-2019 but this does not sound like a recommended approach.
generateFaceCenterPoint unsure why this one is not working for me. Edit: Probably the symbol is not exported automatically as it's a const variable rather than a function.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.