uber / uber/h3

No inlining in library

Open
#325 2 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
6.5k
Forks
627
Avg merge
3d 21h
Merged PRs (30d)
6

Description

Hello,

I'm fighting https://github.com/bytesandbrains/h3-pg/issues/23. Embarrassingly simple invocations aren't getting inlined:

objdump -D ./benchmarkH3Api
image

This also looks quite bad in flamegraph:
image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the reported objdump output for ./benchmarkH3Api and inspect the flamegraph shown in the issue. Trace the relevant library calls and build context to determine why simple invocations are not inlined. Done means the affected invocations are inlined and no longer appear as unnecessary call overhead in the disassembly and flamegraph.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
performance
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.