uber / uber/RIBs

Bundle proguard rules with AAR

Open
#194 0 comments 2 reactions 1 assignee View on GitHub

@AttwellBrian is already working on this.

Since Jan 15, 2018.

Android
Dominant language
Kotlin
Stars
7.9k
Forks
914
PR merge metrics
No merged PRs in 30d

Description

When built with proguard, it throws the following error, adding -dontwarn com.uber.rib.core.** fixes the issue.

Warning: com.uber.rib.core.Interactor_MembersInjector: can't find superclass or interface dagger.MembersInjector
Warning: there were 5 unresolved references to classes or interfaces.
You may need to add missing library jars or update their versions.
If your code works fine without the missing classes, you can suppress
the warnings with '-dontwarn' options.
(http://proguard.sourceforge.net/manual/troubleshooting.html#unresolvedclass)
Error: Please correct the above warnings first.

Bundling pro guard rule with the aar will help us remove the -dontwarn rule safely from the global proguard of the application.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.