uber / uber/RIBs

Best practices to present error when there are viewable and not viewable flow

Open
#160 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

iOS question
Dominant language
Kotlin
Stars
7.9k
Forks
914
PR merge metrics
No merged PRs in 30d

Description

Let's suppose we have:

SignIn (viewable) -> SignInProcessA (not viewable) -> SignInProcessB (not viewable)

Supposing that in SignInProcessB Interactor we had an error, I have some questions:

  • It should call a method from it's listener i.e: self.listener?.hadErrorSigningIn(error) recursively until it arrives at SignIn (viewable) to use presentable like: self.presentable.present(error)?

  • If above answer is right, should I call something like:

    self.router.detach(animated: true) {
        self.listener?.hadErrorSigningIn(error)
    } 

in order to grant that everything was detached when it arrives at SignIn(viewable) ?

Thanks in advance...

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the SignIn, SignInProcessA, and SignInProcessB listener and router flow described in the issue. Determine and document the recommended error-propagation and detachment behavior, including what the viewable SignIn component should present; done means the guidance answers both questions unambiguously.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
mobile
Issue type
Documentation
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.