uber / uber/RIBs-iOS

Combine Support

Open
#21 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement question
Dominant language
Swift
Stars
193
Forks
23
PR merge metrics
No merged PRs in 30d

Description

We've received many questions regarding Combine (https://github.com/uber/RIBs-iOS/issues/20#issuecomment-3177327815, https://github.com/uber/RIBs-iOS/issues/20#issuecomment-3197210637, https://github.com/uber/RIBs/issues/346, ), either about making an integration with it or about rewriting the whole framework with Combine instead of RxSwift.

As @rudro mentioned here: https://github.com/uber/RIBs/issues/346#issuecomment-1230952099, in hindsight, it was a good call not to go with Combine.

We had a conversation about it recently and reaffirmed that there is no need or plans to move RIBs framework to Combine. For backward compatibility reasons and because there is no inherent advantage in doing so, as RIB's usage of Rx is very light.

If you're seeking Combine support with RIBs you can check out https://github.com/DevYeom/ModernRIBs.

Potentially, we will attempt to implement some form of Combine compatibility in the form of convenience methods and mappers/wrapper, akin to https://github.com/CombineCommunity/RxCombine (perhaps by using RxCombine) but this is the last on the list of priorities after SwiftUI and Swift Concurrency (async/await) support and other features.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue describes possible Combine compatibility but states there are no current plans to rewrite RIBs and that this is a low priority. Start by reading the linked discussions and the references to SwiftUI, Swift Concurrency, RxSwift, and RxCombine. There are no files or tests named; completion is not defined beyond a future project decision.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
mobile
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.