Refactor @Contract parsing logic to avoid redundancies.
Open
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 4.1k
- Forks
- 370
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 68
Description
Follow up on #312
We currently have code parsing @Contract annotations that is duplicated between ContractHandler and ContractCheckHandler, this should be common code.
See also https://github.com/uber/NullAway/pull/312#discussion_r492908591 and https://github.com/uber/NullAway/pull/312#discussion_r492910921
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the @Contract parsing logic in ContractHandler and ContractCheckHandler, then review the discussion linked from pull request #312 for the duplication context. Extract the common parsing behavior so both handlers use it, and verify that the two handlers retain their existing behavior without redundant parsing code.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- devtools
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100