uber / uber/NullAway

Optional emptiness check in Rx `map` does not work with method reference

Open
#309 5 comments 0 reactions 1 assignee View on GitHub

@shubhamugare is already working on this.

Since Sep 5, 2019.

Dominant language
Java
Stars
4.1k
Forks
370
Avg merge
1d 13h
Merged PRs (30d)
68

Description

Optional emptiness check in Rx map does not work with method reference:

private static boolean perhaps() { return Math.random() > 0.5; }",
 void foo(Observable<Optional<String>> observable) {
              observable
                  .filter(optional -> optional.isPresent() || perhaps())
                  // should throw an error here, since optional can be empty 
                  .map(Optional::get);
     }

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.