uber / uber/NullAway

Add support for containing class fields to `RxNullabilityPropagator`

Open
#282 1 comment 0 reactions 1 assignee View on GitHub

@lazaroclapp is already working on this.

Since Feb 26, 2019.

lowpriority
Dominant language
Java
Stars
4.1k
Forks
370
Avg merge
1d 13h
Merged PRs (30d)
68

Description

This is to track a known limitation in handling fields from the containing context when dealing with nullability propagation across RxJava filter and map operations.

Here is an illustrative test case that currently produces nullness issues but should be safe:

  private static class FieldFromContext {
      @Nullable public NullableContainer foo;

      private Observable<String> filterThenMapTwoGets(Observable<Void> observable) {
          return observable
                  .filter(unit -> foo != null && foo.get() != null)
                  .map(t -> foo.get().toString());
      }
  }

(add to RxSupportNegativeCases.java)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.