Support JDK 11
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Java
- Stars
- 4.1k
- Forks
- 370
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 68
Description
WIP at https://github.com/uber/NullAway/tree/ms/jdk-11. We should get the core NullAway functionality working first. Some notes:
- I don't think coveralls works yet
- Android-related sample app building will be a pain
- This JarInfer-related code won't work on JDK 11; see here. We should probably disable this handler by default and enable via a flag anyway (along with a couple other rarely-used handlers).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the WIP branch at ms/jdk-11 and first establish the core NullAway functionality that must work on JDK 11. Inspect nullaway/src/main/java/com/uber/nullaway/handlers/InferredJARModelsHandler.java around the linked code, then assess the coveralls and Android sample app notes. Done means core functionality works on JDK 11 and the listed incompatibilities have a decided resolution.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- build-system, tooling
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100